Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Nicolas Zea
CC:
benquan, chromium-apps-reviews_chromium.org, chromium-reviews, Dane Wallinga, dyu1, estade+watch_chromium.org, extensions-reviews_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, maniscalco+watch_chromium.org, mkwst+watchlist_chromium.org, pam+watch_chromium.org, pvalenzuela+watch_chromium.org, rouslan+autofillwatch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in chrome/browser/sync/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=zea@chromium.org Committed: https://crrev.com/0cd9ff92b2dbc83fe8c3664b48041c7ced683c9c Cr-Commit-Position: refs/heads/master@{#300454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+820 lines, -986 lines) Patch
M chrome/browser/sync/backend_unrecoverable_error_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/backup_rollback_controller_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller.h View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 4 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/sync/glue/autofill_profile_data_type_controller.h View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.h View 2 chunks +27 lines, -29 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.h View 1 chunk +11 lines, -12 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.h View 2 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/sync/glue/browser_thread_model_worker.h View 3 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/sync/glue/extension_backed_data_type_controller.h View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/extension_setting_data_type_controller.h View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/extensions_activity_monitor.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/favicon_cache.h View 2 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/favicon_cache_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.h View 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc View 2 chunks +9 lines, -15 lines 0 comments Download
M chrome/browser/sync/glue/history_delete_directives_data_type_controller.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/history_model_worker.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/history_model_worker.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/invalidation_adapter.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/local_device_info_provider_impl.h View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.h View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc View 1 chunk +12 lines, -19 lines 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.h View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/password_model_worker.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/search_engine_data_type_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.h View 2 chunks +23 lines, -30 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.h View 3 chunks +43 lines, -48 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.h View 2 chunks +36 lines, -40 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.h View 2 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_auth_provider.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_auth_provider.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.h View 1 chunk +11 lines, -12 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 6 chunks +43 lines, -53 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 9 chunks +25 lines, -33 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/sync/sessions/notification_service_sessions_router.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/sessions/session_data_type_controller.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/sessions/session_data_type_controller_unittest.cc View 2 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager.h View 1 chunk +16 lines, -18 lines 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 9 chunks +41 lines, -79 lines 0 comments Download
M chrome/browser/sync/startup_controller_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/sync/sync_error_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_global_error.h View 1 chunk +15 lines, -15 lines 0 comments Download
M chrome/browser/sync/sync_global_error_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_global_error_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/sync/sync_policy_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_startup_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/apps_helper.cc View 1 chunk +25 lines, -29 lines 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 4 chunks +30 lines, -35 lines 0 comments Download
M chrome/browser/sync/test/integration/enable_disable_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/extensions_helper.cc View 1 chunk +12 lines, -15 lines 0 comments Download
M chrome/browser/sync/test/integration/fake_server_invalidation_service.h View 2 chunks +12 lines, -14 lines 0 comments Download
M chrome/browser/sync/test/integration/migration_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/migration_waiter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/migration_watcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/multi_client_status_change_checker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/multiple_client_bookmarks_sync_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/multiple_client_passwords_sync_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/multiple_client_preferences_sync_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/multiple_client_typed_urls_sync_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/p2p_invalidation_forwarder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync/test/integration/preferences_helper.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/sync/test/integration/quiesce_status_change_checker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/quiesce_status_change_checker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sessions_helper.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/single_client_status_change_checker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_supervised_user_settings_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_auth_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_errors_test.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_extension_installer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_integration_test_util.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/sync/test/integration/themes_helper.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_apps_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_autofill_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_extensions_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_passwords_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_themes_sync_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 6 chunks +23 lines, -23 lines 0 comments Download
M chrome/browser/sync/test/integration/updated_progress_marker_checker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/test_http_bridge_factory.h View 1 chunk +14 lines, -16 lines 0 comments Download
M chrome/browser/sync/test_profile_sync_service.h View 4 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 10:11:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666733003/1
6 years, 2 months ago (2014-10-21 10:14:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 11:13:23 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 11:13:57 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0cd9ff92b2dbc83fe8c3664b48041c7ced683c9c
Cr-Commit-Position: refs/heads/master@{#300454}

Powered by Google App Engine
This is Rietveld 408576698