chrome/browser/sync/sessions/notification_service_sessions_router.h - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sessions/notification_service_sessions_router.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_unittest.cc ('k') | chrome/browser/sync/sessions/session_data_type_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sessions/notification_service_sessions_router.h

diff --git a/chrome/browser/sync/sessions/notification_service_sessions_router.h b/chrome/browser/sync/sessions/notification_service_sessions_router.h

index 76a020c740749e6b701ba448721cb2b9537c82e0..f1249f19c2b5af626dc32a9e457d7ecb40f55aec 100644

--- a/chrome/browser/sync/sessions/notification_service_sessions_router.h

+++ b/chrome/browser/sync/sessions/notification_service_sessions_router.h

@@ -32,17 +32,17 @@ class NotificationServiceSessionsRouter

NotificationServiceSessionsRouter(

Profile* profile,

const syncer::SyncableService::StartSyncFlare& flare);

- virtual ~NotificationServiceSessionsRouter();

+ ~NotificationServiceSessionsRouter() override;

// content::NotificationObserver implementation.

// BrowserSessionProvider -> sync API model change application.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// SessionsSyncManager::LocalEventRouter implementation.

- virtual void StartRoutingTo(LocalSessionEventHandler* handler) override;

- virtual void Stop() override;

+ void StartRoutingTo(LocalSessionEventHandler* handler) override;

+ void Stop() override;

private:

// Called when the URL visited in |web_contents| was blocked by the