chrome/browser/sync/glue/autofill_data_type_controller.h - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/autofill_data_type_controller.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/backup_rollback_controller_unittest.cc ('k') | chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/autofill_data_type_controller.h

diff --git a/chrome/browser/sync/glue/autofill_data_type_controller.h b/chrome/browser/sync/glue/autofill_data_type_controller.h

index f96e149fa9d135bb7bb34e2df2db994ed66271c1..f8f8b59f9512f11dc52e6ccee985a81d3ee5c7a7 100644

--- a/chrome/browser/sync/glue/autofill_data_type_controller.h

+++ b/chrome/browser/sync/glue/autofill_data_type_controller.h

@@ -30,21 +30,20 @@ class AutofillDataTypeController

Profile* profile);

// NonUIDataTypeController implementation.

- virtual syncer::ModelType type() const override;

- virtual syncer::ModelSafeGroup model_safe_group() const override;

+ syncer::ModelType type() const override;

+ syncer::ModelSafeGroup model_safe_group() const override;

// NonFrontendDatatypeController override, needed as stop-gap until bug

// 163431 is addressed / implemented.

- virtual void StartAssociating(const StartCallback& start_callback) override;

+ void StartAssociating(const StartCallback& start_callback) override;

protected:

- virtual ~AutofillDataTypeController();

+ ~AutofillDataTypeController() override;

// NonUIDataTypeController implementation.

- virtual bool PostTaskOnBackendThread(

- const tracked_objects::Location& from_here,

- const base::Closure& task) override;

- virtual bool StartModels() override;

+ bool PostTaskOnBackendThread(const tracked_objects::Location& from_here,

+ const base::Closure& task) override;

+ bool StartModels() override;

private:

friend class AutofillDataTypeControllerTest;