chrome/browser/sync/test/integration/migration_test.cc - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/migration_test.cc

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/fake_server_invalidation_service.h ('k') | chrome/browser/sync/test/integration/migration_waiter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/migration_test.cc

diff --git a/chrome/browser/sync/test/integration/migration_test.cc b/chrome/browser/sync/test/integration/migration_test.cc

index 276a29c00752fac373482cc118a0fb7b5807714c..ef2ac1ec43fa88065974b225ec3551b375394f66 100644

--- a/chrome/browser/sync/test/integration/migration_test.cc

+++ b/chrome/browser/sync/test/integration/migration_test.cc

@@ -77,7 +77,7 @@ class MigrationTest : public SyncTest {

// Set up sync for all profiles and initialize all MigrationWatchers. This

// helps ensure that all migration events are captured, even if they were to

// occur before a test calls AwaitMigration for a specific profile.

- virtual bool SetupSync() override {

+ bool SetupSync() override {

if (!SyncTest::SetupSync())

return false;

@@ -421,7 +421,7 @@ class MigrationReconfigureTest : public MigrationTwoClientTest {

public:

MigrationReconfigureTest() {}

- virtual void SetUpCommandLine(base::CommandLine* cl) override {

+ void SetUpCommandLine(base::CommandLine* cl) override {

AddTestSwitches(cl);

// Do not add optional datatypes.

}