Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3838)

Unified Diff: chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc b/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
index 22df3eb3d20408c0cc0c6382b8ec28c2e9c471e6..ffa75457818aea387cc3f8c7d5f0817782fbc27c 100644
--- a/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
@@ -41,14 +41,14 @@ using testing::Return;
class NoOpAutofillBackend : public AutofillWebDataBackend {
public:
NoOpAutofillBackend() {}
- virtual ~NoOpAutofillBackend() {}
- virtual WebDatabase* GetDatabase() override { return NULL; }
- virtual void AddObserver(
+ ~NoOpAutofillBackend() override {}
+ WebDatabase* GetDatabase() override { return NULL; }
+ void AddObserver(
autofill::AutofillWebDataServiceObserverOnDBThread* observer) override {}
- virtual void RemoveObserver(
+ void RemoveObserver(
autofill::AutofillWebDataServiceObserverOnDBThread* observer) override {}
- virtual void RemoveExpiredFormElements() override {}
- virtual void NotifyOfMultipleAutofillChanges() override {}
+ void RemoveExpiredFormElements() override {}
+ void NotifyOfMultipleAutofillChanges() override {}
};
// Fake WebDataService implementation that stubs out the database loading.
@@ -70,11 +70,9 @@ class FakeWebDataService : public AutofillWebDataService {
db_loaded_callback_.Run();
}
- virtual bool IsDatabaseLoaded() override {
- return is_database_loaded_;
- }
+ bool IsDatabaseLoaded() override { return is_database_loaded_; }
- virtual void RegisterDBLoadedCallback(
+ void RegisterDBLoadedCallback(
const base::Callback<void(void)>& callback) override {
db_loaded_callback_ = callback;
}
@@ -90,8 +88,7 @@ class FakeWebDataService : public AutofillWebDataService {
}
private:
- virtual ~FakeWebDataService() {
- }
+ ~FakeWebDataService() override {}
void CreateSyncableService() {
ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));
@@ -118,7 +115,7 @@ class MockWebDataServiceWrapperSyncable : public MockWebDataServiceWrapper {
: MockWebDataServiceWrapper(new FakeWebDataService(), NULL) {
}
- virtual void Shutdown() override {
+ void Shutdown() override {
static_cast<FakeWebDataService*>(
fake_autofill_web_data_.get())->ShutdownOnUIThread();
// Make sure WebDataService is shutdown properly on DB thread before we

Powered by Google App Engine
This is Rietveld 408576698