Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: chrome/browser/sync/sync_error_controller.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_SYNC_ERROR_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_SYNC_SYNC_ERROR_CONTROLLER_H_
6 #define CHROME_BROWSER_SYNC_SYNC_ERROR_CONTROLLER_H_ 6 #define CHROME_BROWSER_SYNC_SYNC_ERROR_CONTROLLER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/observer_list.h" 10 #include "base/observer_list.h"
11 #include "chrome/browser/sync/profile_sync_service_observer.h" 11 #include "chrome/browser/sync/profile_sync_service_observer.h"
12 12
13 class Profile; 13 class Profile;
14 class ProfileSyncService; 14 class ProfileSyncService;
15 15
16 // Keep track of sync errors and expose them to observers in the UI. 16 // Keep track of sync errors and expose them to observers in the UI.
17 class SyncErrorController : public ProfileSyncServiceObserver { 17 class SyncErrorController : public ProfileSyncServiceObserver {
18 public: 18 public:
19 // The observer class for SyncErrorController lets the controller notify 19 // The observer class for SyncErrorController lets the controller notify
20 // observers when an error arises or changes. 20 // observers when an error arises or changes.
21 class Observer { 21 class Observer {
22 public: 22 public:
23 virtual ~Observer() {} 23 virtual ~Observer() {}
24 virtual void OnErrorChanged() = 0; 24 virtual void OnErrorChanged() = 0;
25 }; 25 };
26 26
27 explicit SyncErrorController(ProfileSyncService* service); 27 explicit SyncErrorController(ProfileSyncService* service);
28 virtual ~SyncErrorController(); 28 ~SyncErrorController() override;
29 29
30 // True if there exists an error worth elevating to the user. 30 // True if there exists an error worth elevating to the user.
31 bool HasError(); 31 bool HasError();
32 32
33 void AddObserver(Observer* observer); 33 void AddObserver(Observer* observer);
34 void RemoveObserver(Observer* observer); 34 void RemoveObserver(Observer* observer);
35 35
36 // ProfileSyncServiceObserver: 36 // ProfileSyncServiceObserver:
37 virtual void OnStateChanged() override; 37 void OnStateChanged() override;
38 38
39 private: 39 private:
40 ProfileSyncService* service_; 40 ProfileSyncService* service_;
41 ObserverList<Observer, true> observer_list_; 41 ObserverList<Observer, true> observer_list_;
42 42
43 DISALLOW_COPY_AND_ASSIGN(SyncErrorController); 43 DISALLOW_COPY_AND_ASSIGN(SyncErrorController);
44 }; 44 };
45 45
46 #endif // CHROME_BROWSER_SYNC_SYNC_ERROR_CONTROLLER_H_ 46 #endif // CHROME_BROWSER_SYNC_SYNC_ERROR_CONTROLLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/startup_controller_unittest.cc ('k') | chrome/browser/sync/sync_global_error.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698