chrome/browser/sync/glue/extension_backed_data_type_controller.h - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/extension_backed_data_type_controller.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/browser_thread_model_worker.h ('k') | chrome/browser/sync/glue/extension_data_type_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/extension_backed_data_type_controller.h

diff --git a/chrome/browser/sync/glue/extension_backed_data_type_controller.h b/chrome/browser/sync/glue/extension_backed_data_type_controller.h

index 96696062a09ab60a3f4b6a308446974e35db97f4..dbe9ad731df7ee4e9a96a7cfdec7290af220b291 100644

--- a/chrome/browser/sync/glue/extension_backed_data_type_controller.h

+++ b/chrome/browser/sync/glue/extension_backed_data_type_controller.h

@@ -28,21 +28,20 @@ class ExtensionBackedDataTypeController

Profile* profile);

// UIDataTypeController overrides.

- virtual bool ReadyForStart() const override;

- virtual bool StartModels() override;

+ bool ReadyForStart() const override;

+ bool StartModels() override;

// ExtensionRegistryObserver implementation.

- virtual void OnExtensionLoaded(

- content::BrowserContext* browser_context,

- const extensions::Extension* extension) override;

- virtual void OnExtensionUnloaded(

+ void OnExtensionLoaded(content::BrowserContext* browser_context,

+ const extensions::Extension* extension) override;

+ void OnExtensionUnloaded(

content::BrowserContext* browser_context,

const extensions::Extension* extension,

extensions::UnloadedExtensionInfo::Reason reason) override;

private:

// Refcounted via DataTypeController.

- virtual ~ExtensionBackedDataTypeController();

+ ~ExtensionBackedDataTypeController() override;

// Returns whether the extension syncing this type is enabled.

bool IsSyncingExtensionEnabled() const;