Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/browser/sync/profile_sync_components_factory_impl.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 5 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 6 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 22 matching lines...) Expand all
33 // |token_service| must outlive the ProfileSyncComponentsFactoryImpl. 33 // |token_service| must outlive the ProfileSyncComponentsFactoryImpl.
34 // 34 //
35 // |url_request_context_getter| must outlive the 35 // |url_request_context_getter| must outlive the
36 // ProfileSyncComponentsFactoryImpl. 36 // ProfileSyncComponentsFactoryImpl.
37 ProfileSyncComponentsFactoryImpl( 37 ProfileSyncComponentsFactoryImpl(
38 Profile* profile, 38 Profile* profile,
39 base::CommandLine* command_line, 39 base::CommandLine* command_line,
40 const GURL& sync_service_url, 40 const GURL& sync_service_url,
41 OAuth2TokenService* token_service, 41 OAuth2TokenService* token_service,
42 net::URLRequestContextGetter* url_request_context_getter); 42 net::URLRequestContextGetter* url_request_context_getter);
43 virtual ~ProfileSyncComponentsFactoryImpl(); 43 ~ProfileSyncComponentsFactoryImpl() override;
44 44
45 virtual void RegisterDataTypes(ProfileSyncService* pss) override; 45 void RegisterDataTypes(ProfileSyncService* pss) override;
46 46
47 virtual sync_driver::DataTypeManager* CreateDataTypeManager( 47 sync_driver::DataTypeManager* CreateDataTypeManager(
48 const syncer::WeakHandle<syncer::DataTypeDebugInfoListener>& 48 const syncer::WeakHandle<syncer::DataTypeDebugInfoListener>&
49 debug_info_listener, 49 debug_info_listener,
50 const sync_driver::DataTypeController::TypeMap* controllers, 50 const sync_driver::DataTypeController::TypeMap* controllers,
51 const sync_driver::DataTypeEncryptionHandler* encryption_handler, 51 const sync_driver::DataTypeEncryptionHandler* encryption_handler,
52 browser_sync::SyncBackendHost* backend, 52 browser_sync::SyncBackendHost* backend,
53 sync_driver::DataTypeManagerObserver* observer) 53 sync_driver::DataTypeManagerObserver* observer) override;
54 override;
55 54
56 virtual browser_sync::SyncBackendHost* CreateSyncBackendHost( 55 browser_sync::SyncBackendHost* CreateSyncBackendHost(
57 const std::string& name, 56 const std::string& name,
58 Profile* profile, 57 Profile* profile,
59 invalidation::InvalidationService* invalidator, 58 invalidation::InvalidationService* invalidator,
60 const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs, 59 const base::WeakPtr<sync_driver::SyncPrefs>& sync_prefs,
61 const base::FilePath& sync_folder) override; 60 const base::FilePath& sync_folder) override;
62 61
63 virtual scoped_ptr<sync_driver::LocalDeviceInfoProvider> 62 scoped_ptr<sync_driver::LocalDeviceInfoProvider>
64 CreateLocalDeviceInfoProvider() override; 63 CreateLocalDeviceInfoProvider() override;
65 64
66 virtual base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType( 65 base::WeakPtr<syncer::SyncableService> GetSyncableServiceForType(
67 syncer::ModelType type) override; 66 syncer::ModelType type) override;
68 virtual scoped_ptr<syncer::AttachmentService> CreateAttachmentService( 67 scoped_ptr<syncer::AttachmentService> CreateAttachmentService(
69 const scoped_refptr<syncer::AttachmentStore>& attachment_store, 68 const scoped_refptr<syncer::AttachmentStore>& attachment_store,
70 const syncer::UserShare& user_share, 69 const syncer::UserShare& user_share,
71 syncer::AttachmentService::Delegate* delegate) override; 70 syncer::AttachmentService::Delegate* delegate) override;
72 71
73 // Legacy datatypes that need to be converted to the SyncableService API. 72 // Legacy datatypes that need to be converted to the SyncableService API.
74 virtual SyncComponents CreateBookmarkSyncComponents( 73 SyncComponents CreateBookmarkSyncComponents(
75 ProfileSyncService* profile_sync_service, 74 ProfileSyncService* profile_sync_service,
76 sync_driver::DataTypeErrorHandler* error_handler) override; 75 sync_driver::DataTypeErrorHandler* error_handler) override;
77 virtual SyncComponents CreateTypedUrlSyncComponents( 76 SyncComponents CreateTypedUrlSyncComponents(
78 ProfileSyncService* profile_sync_service, 77 ProfileSyncService* profile_sync_service,
79 history::HistoryBackend* history_backend, 78 history::HistoryBackend* history_backend,
80 sync_driver::DataTypeErrorHandler* error_handler) override; 79 sync_driver::DataTypeErrorHandler* error_handler) override;
81 80
82 private: 81 private:
83 // Register data types which are enabled on desktop platforms only. 82 // Register data types which are enabled on desktop platforms only.
84 // |disabled_types| and |enabled_types| correspond only to those types 83 // |disabled_types| and |enabled_types| correspond only to those types
85 // being explicitly enabled/disabled by the command line. 84 // being explicitly enabled/disabled by the command line.
86 void RegisterDesktopDataTypes(syncer::ModelTypeSet disabled_types, 85 void RegisterDesktopDataTypes(syncer::ModelTypeSet disabled_types,
87 syncer::ModelTypeSet enabled_types, 86 syncer::ModelTypeSet enabled_types,
(...skipping 19 matching lines...) Expand all
107 const GURL sync_service_url_; 106 const GURL sync_service_url_;
108 OAuth2TokenService* const token_service_; 107 OAuth2TokenService* const token_service_;
109 net::URLRequestContextGetter* const url_request_context_getter_; 108 net::URLRequestContextGetter* const url_request_context_getter_;
110 109
111 base::WeakPtrFactory<ProfileSyncComponentsFactoryImpl> weak_factory_; 110 base::WeakPtrFactory<ProfileSyncComponentsFactoryImpl> weak_factory_;
112 111
113 DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl); 112 DISALLOW_COPY_AND_ASSIGN(ProfileSyncComponentsFactoryImpl);
114 }; 113 };
115 114
116 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__ 115 #endif // CHROME_BROWSER_SYNC_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__
OLDNEW
« no previous file with comments | « chrome/browser/sync/profile_sync_components_factory.h ('k') | chrome/browser/sync/profile_sync_components_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698