Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/sync/test/integration/quiesce_status_change_checker.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_QUIESCE_STATUS_CHANGE_CHECKER_H_ 5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_QUIESCE_STATUS_CHANGE_CHECKER_H_
6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_QUIESCE_STATUS_CHANGE_CHECKER_H_ 6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_QUIESCE_STATUS_CHANGE_CHECKER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 14 matching lines...) Expand all
25 // 25 //
26 // There is a race condition here. If we manage to perform the check at 26 // There is a race condition here. If we manage to perform the check at
27 // precisely the wrong time, we could end up seeing stale snapshot state 27 // precisely the wrong time, we could end up seeing stale snapshot state
28 // (crbug.com/95742), which would make us think that the client has finished 28 // (crbug.com/95742), which would make us think that the client has finished
29 // syncing when it hasn't. In practice, this race is rare enough that it 29 // syncing when it hasn't. In practice, this race is rare enough that it
30 // doesn't cause test failures. 30 // doesn't cause test failures.
31 class QuiesceStatusChangeChecker : public StatusChangeChecker { 31 class QuiesceStatusChangeChecker : public StatusChangeChecker {
32 public: 32 public:
33 explicit QuiesceStatusChangeChecker( 33 explicit QuiesceStatusChangeChecker(
34 std::vector<ProfileSyncService*> services); 34 std::vector<ProfileSyncService*> services);
35 virtual ~QuiesceStatusChangeChecker(); 35 ~QuiesceStatusChangeChecker() override;
36 36
37 // Blocks until all clients have quiesced or we time out. 37 // Blocks until all clients have quiesced or we time out.
38 void Wait(); 38 void Wait();
39 39
40 // A callback function for some helper objects. 40 // A callback function for some helper objects.
41 void OnServiceStateChanged(ProfileSyncService* service); 41 void OnServiceStateChanged(ProfileSyncService* service);
42 42
43 // Implementation of StatusChangeChecker. 43 // Implementation of StatusChangeChecker.
44 virtual bool IsExitConditionSatisfied() override; 44 bool IsExitConditionSatisfied() override;
45 virtual std::string GetDebugMessage() const override; 45 std::string GetDebugMessage() const override;
46 46
47 private: 47 private:
48 std::vector<ProfileSyncService*> services_; 48 std::vector<ProfileSyncService*> services_;
49 ScopedVector<ProgressMarkerWatcher> observers_; 49 ScopedVector<ProgressMarkerWatcher> observers_;
50 50
51 DISALLOW_COPY_AND_ASSIGN(QuiesceStatusChangeChecker); 51 DISALLOW_COPY_AND_ASSIGN(QuiesceStatusChangeChecker);
52 }; 52 };
53 53
54 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_QUIESCE_STATUS_CHANGE_CHECKER_H_ 54 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_QUIESCE_STATUS_CHANGE_CHECKER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698