Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: chrome/browser/sync/test/integration/sync_test.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_ 5 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_
6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_ 6 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 virtual ~SyncTest(); 100 virtual ~SyncTest();
101 101
102 // Validates command line parameters and creates a local python test server if 102 // Validates command line parameters and creates a local python test server if
103 // specified. 103 // specified.
104 virtual void SetUp() override; 104 virtual void SetUp() override;
105 105
106 // Brings down local python test server if one was created. 106 // Brings down local python test server if one was created.
107 virtual void TearDown() override; 107 virtual void TearDown() override;
108 108
109 // Sets up command line flags required for sync tests. 109 // Sets up command line flags required for sync tests.
110 virtual void SetUpCommandLine(base::CommandLine* cl) override; 110 void SetUpCommandLine(base::CommandLine* cl) override;
111 111
112 // Used to get the number of sync clients used by a test. 112 // Used to get the number of sync clients used by a test.
113 int num_clients() WARN_UNUSED_RESULT { return num_clients_; } 113 int num_clients() WARN_UNUSED_RESULT { return num_clients_; }
114 114
115 // Returns a pointer to a particular sync profile. Callee owns the object 115 // Returns a pointer to a particular sync profile. Callee owns the object
116 // and manages its lifetime. 116 // and manages its lifetime.
117 Profile* GetProfile(int index) WARN_UNUSED_RESULT; 117 Profile* GetProfile(int index) WARN_UNUSED_RESULT;
118 118
119 // Returns a pointer to a particular browser. Callee owns the object 119 // Returns a pointer to a particular browser. Callee owns the object
120 // and manages its lifetime. 120 // and manages its lifetime.
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 protected: 220 protected:
221 // Add custom switches needed for running the test. 221 // Add custom switches needed for running the test.
222 virtual void AddTestSwitches(base::CommandLine* cl); 222 virtual void AddTestSwitches(base::CommandLine* cl);
223 223
224 // Append the command line switches to enable experimental types that aren't 224 // Append the command line switches to enable experimental types that aren't
225 // on by default yet. 225 // on by default yet.
226 virtual void AddOptionalTypesToCommandLine(base::CommandLine* cl); 226 virtual void AddOptionalTypesToCommandLine(base::CommandLine* cl);
227 227
228 // BrowserTestBase override. Destroys all the sync clients and sync 228 // BrowserTestBase override. Destroys all the sync clients and sync
229 // profiles created by a test. 229 // profiles created by a test.
230 virtual void TearDownOnMainThread() override; 230 void TearDownOnMainThread() override;
231 231
232 // InProcessBrowserTest override. Changes behavior of the default host 232 // InProcessBrowserTest override. Changes behavior of the default host
233 // resolver to avoid DNS lookup errors. 233 // resolver to avoid DNS lookup errors.
234 virtual void SetUpInProcessBrowserTestFixture() override; 234 void SetUpInProcessBrowserTestFixture() override;
235 235
236 // InProcessBrowserTest override. Resets the host resolver its default 236 // InProcessBrowserTest override. Resets the host resolver its default
237 // behavior. 237 // behavior.
238 virtual void TearDownInProcessBrowserTestFixture() override; 238 void TearDownInProcessBrowserTestFixture() override;
239 239
240 // Creates Profile, Browser and ProfileSyncServiceHarness instances for 240 // Creates Profile, Browser and ProfileSyncServiceHarness instances for
241 // |index|. Used by SetupClients(). 241 // |index|. Used by SetupClients().
242 virtual void InitializeInstance(int index); 242 virtual void InitializeInstance(int index);
243 243
244 // Implementations of the EnableNotifications() and DisableNotifications() 244 // Implementations of the EnableNotifications() and DisableNotifications()
245 // functions defined above. 245 // functions defined above.
246 void DisableNotificationsImpl(); 246 void DisableNotificationsImpl();
247 void EnableNotificationsImpl(); 247 void EnableNotificationsImpl();
248 248
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 // Fake URLFetcher factory used to mock out GAIA signin. 381 // Fake URLFetcher factory used to mock out GAIA signin.
382 scoped_ptr<net::FakeURLFetcherFactory> fake_factory_; 382 scoped_ptr<net::FakeURLFetcherFactory> fake_factory_;
383 383
384 // The URLFetcherImplFactory instance used to instantiate |fake_factory_|. 384 // The URLFetcherImplFactory instance used to instantiate |fake_factory_|.
385 scoped_ptr<net::URLFetcherImplFactory> factory_; 385 scoped_ptr<net::URLFetcherImplFactory> factory_;
386 386
387 DISALLOW_COPY_AND_ASSIGN(SyncTest); 387 DISALLOW_COPY_AND_ASSIGN(SyncTest);
388 }; 388 };
389 389
390 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_ 390 #endif // CHROME_BROWSER_SYNC_TEST_INTEGRATION_SYNC_TEST_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/test/integration/sync_integration_test_util.cc ('k') | chrome/browser/sync/test/integration/sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698