chrome/browser/sync/test/integration/quiesce_status_change_checker.h - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/quiesce_status_change_checker.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/profile_sync_service_harness.cc ('k') | chrome/browser/sync/test/integration/quiesce_status_change_checker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/quiesce_status_change_checker.h

diff --git a/chrome/browser/sync/test/integration/quiesce_status_change_checker.h b/chrome/browser/sync/test/integration/quiesce_status_change_checker.h

index 246d3baba626501f8aaa09b99d1031dbce5efcb9..e481227474d46fc7fff4d47fe35b7ffdc50f777f 100644

--- a/chrome/browser/sync/test/integration/quiesce_status_change_checker.h

+++ b/chrome/browser/sync/test/integration/quiesce_status_change_checker.h

@@ -32,7 +32,7 @@ class QuiesceStatusChangeChecker : public StatusChangeChecker {

public:

explicit QuiesceStatusChangeChecker(

std::vector<ProfileSyncService*> services);

- virtual ~QuiesceStatusChangeChecker();

+ ~QuiesceStatusChangeChecker() override;

// Blocks until all clients have quiesced or we time out.

void Wait();

@@ -41,8 +41,8 @@ class QuiesceStatusChangeChecker : public StatusChangeChecker {

void OnServiceStateChanged(ProfileSyncService* service);

// Implementation of StatusChangeChecker.

- virtual bool IsExitConditionSatisfied() override;

- virtual std::string GetDebugMessage() const override;

+ bool IsExitConditionSatisfied() override;

+ std::string GetDebugMessage() const override;

private:

std::vector<ProfileSyncService*> services_;