chrome/browser/sync/sync_startup_tracker.h - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_startup_tracker.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/sync_startup_tracker.h

diff --git a/chrome/browser/sync/sync_startup_tracker.h b/chrome/browser/sync/sync_startup_tracker.h

index acffd29c7ffa487f12d1b819e0c873e36fa6699c..acac4a0b31634600cf9471e54156e55a52741e9c 100644

--- a/chrome/browser/sync/sync_startup_tracker.h

+++ b/chrome/browser/sync/sync_startup_tracker.h

@@ -29,7 +29,7 @@ class SyncStartupTracker : public ProfileSyncServiceObserver {

};

SyncStartupTracker(Profile* profile, Observer* observer);

- virtual ~SyncStartupTracker();

+ ~SyncStartupTracker() override;

enum SyncServiceState {

// Sync backend is still starting up.

@@ -46,7 +46,7 @@ class SyncStartupTracker : public ProfileSyncServiceObserver {

static SyncServiceState GetSyncServiceState(Profile* profile);

// ProfileSyncServiceObserver implementation.

- virtual void OnStateChanged() override;

+ void OnStateChanged() override;

private:

// Checks the current service state and notifies |observer_| if the state

« no previous file with comments | « chrome/browser/sync/sync_policy_handler.h ('k') | chrome/browser/sync/sync_ui_util_unittest.cc » ('j') | no next file with comments »