chrome/browser/sync/glue/history_delete_directives_data_type_controller.h - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/history_delete_directives_data_type_controller.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/frontend_data_type_controller_unittest.cc ('k') | chrome/browser/sync/glue/history_model_worker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/history_delete_directives_data_type_controller.h

diff --git a/chrome/browser/sync/glue/history_delete_directives_data_type_controller.h b/chrome/browser/sync/glue/history_delete_directives_data_type_controller.h

index ac5629074889fc4f7d9fd4ea7af60c19c3d7c035..4f7e24e7b878e489f6c5916174e9c5fa7f9469a0 100644

--- a/chrome/browser/sync/glue/history_delete_directives_data_type_controller.h

+++ b/chrome/browser/sync/glue/history_delete_directives_data_type_controller.h

@@ -25,16 +25,16 @@ class HistoryDeleteDirectivesDataTypeController

ProfileSyncService* sync_service);

// UIDataTypeController override.

- virtual bool ReadyForStart() const override;

- virtual bool StartModels() override;

- virtual void StopModels() override;

+ bool ReadyForStart() const override;

+ bool StartModels() override;

+ void StopModels() override;

// ProfileSyncServiceBaseObserver implementation.

- virtual void OnStateChanged() override;

+ void OnStateChanged() override;

private:

// Refcounted.

- virtual ~HistoryDeleteDirectivesDataTypeController();

+ ~HistoryDeleteDirectivesDataTypeController() override;

// Triggers a SingleDataTypeUnrecoverable error and returns true if the

// type is no longer ready, else does nothing and returns false.