chrome/browser/sync/sessions/session_data_type_controller.h - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sessions/session_data_type_controller.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/sessions/notification_service_sessions_router.h ('k') | chrome/browser/sync/sessions/session_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sessions/session_data_type_controller.h

diff --git a/chrome/browser/sync/sessions/session_data_type_controller.h b/chrome/browser/sync/sessions/session_data_type_controller.h

index b018d4984d6b1aea1f255b73a61ce61efeb8152d..f7d92fa568e49c461de2e0b321697b6e63180483 100644

--- a/chrome/browser/sync/sessions/session_data_type_controller.h

+++ b/chrome/browser/sync/sessions/session_data_type_controller.h

@@ -29,17 +29,17 @@ class SessionDataTypeController : public sync_driver::UIDataTypeController,

sync_driver::LocalDeviceInfoProvider* local_device);

// NotificationObserver interface.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// UIDataTypeController interface.

- virtual bool StartModels() override;

- virtual void StopModels() override;

- virtual bool ReadyForStart() const override;

+ bool StartModels() override;

+ void StopModels() override;

+ bool ReadyForStart() const override;

protected:

- virtual ~SessionDataTypeController();

+ ~SessionDataTypeController() override;

private:

bool IsWaiting();