chrome/browser/sync/profile_sync_service_bookmark_unittest.cc - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_autofill_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

index ba0feda8da59242a3eff95228141804ef230da15..bd7a38cdafcde9d95e212d059958bdc32a564f3f 100644

--- a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

@@ -279,17 +279,16 @@ class ExtensiveChangesBookmarkModelObserver : public BaseBookmarkModelObserver {

completed_count_at_started_(0),

completed_count_(0) {}

- virtual void ExtensiveBookmarkChangesBeginning(

- BookmarkModel* model) override {

+ void ExtensiveBookmarkChangesBeginning(BookmarkModel* model) override {

++started_count_;

completed_count_at_started_ = completed_count_;

}

- virtual void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override {

+ void ExtensiveBookmarkChangesEnded(BookmarkModel* model) override {

++completed_count_;

}

- virtual void BookmarkModelChanged() override {}

+ void BookmarkModelChanged() override {}

int get_started() const {

return started_count_;