chrome/browser/sync/sync_error_controller.h - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_error_controller.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/sync_error_controller.h

diff --git a/chrome/browser/sync/sync_error_controller.h b/chrome/browser/sync/sync_error_controller.h

index 8784c3affbade5127fe592743f74a41fee7762a9..e8cd7305a8b0021c6ff7c7a7acd4a90b2718e997 100644

--- a/chrome/browser/sync/sync_error_controller.h

+++ b/chrome/browser/sync/sync_error_controller.h

@@ -25,7 +25,7 @@ class SyncErrorController : public ProfileSyncServiceObserver {

};

explicit SyncErrorController(ProfileSyncService* service);

- virtual ~SyncErrorController();

+ ~SyncErrorController() override;

// True if there exists an error worth elevating to the user.

bool HasError();

@@ -34,7 +34,7 @@ class SyncErrorController : public ProfileSyncServiceObserver {

void RemoveObserver(Observer* observer);

// ProfileSyncServiceObserver:

- virtual void OnStateChanged() override;

+ void OnStateChanged() override;

private:

ProfileSyncService* service_;

« no previous file with comments | « chrome/browser/sync/startup_controller_unittest.cc ('k') | chrome/browser/sync/sync_global_error.h » ('j') | no next file with comments »