chrome/browser/sync/test/integration/passwords_helper.cc - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/passwords_helper.cc

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/p2p_invalidation_forwarder.h ('k') | chrome/browser/sync/test/integration/preferences_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/passwords_helper.cc

diff --git a/chrome/browser/sync/test/integration/passwords_helper.cc b/chrome/browser/sync/test/integration/passwords_helper.cc

index c92ab67c24118454409326022493449bd2b4cf17..331bc0006819cd685f1ea5376eb1e218fc6a7558 100644

--- a/chrome/browser/sync/test/integration/passwords_helper.cc

+++ b/chrome/browser/sync/test/integration/passwords_helper.cc

@@ -44,7 +44,7 @@ class PasswordStoreConsumerHelper

explicit PasswordStoreConsumerHelper(std::vector<PasswordForm>* result)

: password_manager::PasswordStoreConsumer(), result_(result) {}

- virtual void OnGetPasswordStoreResults(

+ void OnGetPasswordStoreResults(

const std::vector<PasswordForm*>& result) override {

result_->clear();

for (std::vector<PasswordForm*>::const_iterator it = result.begin();

@@ -217,10 +217,10 @@ namespace {

class SamePasswordFormsChecker : public MultiClientStatusChangeChecker {

public:

SamePasswordFormsChecker();

- virtual ~SamePasswordFormsChecker();

+ ~SamePasswordFormsChecker() override;

- virtual bool IsExitConditionSatisfied() override;

- virtual std::string GetDebugMessage() const override;

+ bool IsExitConditionSatisfied() override;

+ std::string GetDebugMessage() const override;

private:

bool in_progress_;

@@ -287,10 +287,10 @@ class SamePasswordFormsAsVerifierChecker

: public SingleClientStatusChangeChecker {

public:

explicit SamePasswordFormsAsVerifierChecker(int index);

- virtual ~SamePasswordFormsAsVerifierChecker();

+ ~SamePasswordFormsAsVerifierChecker() override;

- virtual bool IsExitConditionSatisfied() override;

- virtual std::string GetDebugMessage() const override;

+ bool IsExitConditionSatisfied() override;

+ std::string GetDebugMessage() const override;

private:

int index_;