chrome/browser/sync/glue/password_model_worker.h - Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/password_model_worker.h

Issue 666733003: Standardize usage of virtual/override/final in chrome/browser/sync/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/password_data_type_controller.h ('k') | chrome/browser/sync/glue/search_engine_data_type_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/password_model_worker.h

diff --git a/chrome/browser/sync/glue/password_model_worker.h b/chrome/browser/sync/glue/password_model_worker.h

index eeccc8b3302b996abb944ae2740175509a1c644d..d296b02d3984cd26df446fc5962b789dcb2ed03d 100644

--- a/chrome/browser/sync/glue/password_model_worker.h

+++ b/chrome/browser/sync/glue/password_model_worker.h

@@ -32,16 +32,16 @@ class PasswordModelWorker : public syncer::ModelSafeWorker {

syncer::WorkerLoopDestructionObserver* observer);

// syncer::ModelSafeWorker implementation. Called on syncapi SyncerThread.

- virtual void RegisterForLoopDestruction() override;

- virtual syncer::ModelSafeGroup GetModelSafeGroup() override;

- virtual void RequestStop() override;

+ void RegisterForLoopDestruction() override;

+ syncer::ModelSafeGroup GetModelSafeGroup() override;

+ void RequestStop() override;

protected:

- virtual syncer::SyncerError DoWorkAndWaitUntilDoneImpl(

+ syncer::SyncerError DoWorkAndWaitUntilDoneImpl(

const syncer::WorkCallback& work) override;

private:

- virtual ~PasswordModelWorker();

+ ~PasswordModelWorker() override;

void CallDoWorkAndSignalTask(

const syncer::WorkCallback& work,