Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews, asanka, posciak+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, viettrungluu+watch_chromium.org, tburkard+watch_chromium.org, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, mkwst+watchlist_chromium.org, yusukes+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, Aaron Boodman, benjhayden+dwatch_chromium.org, Ilya Sherman, tzik, jam, ben+mojo_chromium.org, abarth-chromium, nona+watch_chromium.org, darin-cc_chromium.org, michaeln, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, Dane Wallinga, chrome-apps-syd-reviews_chromium.org, creis+watch_chromium.org, dtseng+watch_chromium.org, qsr+mojo_chromium.org, yuzo+watch_chromium.org, wfh+watch_chromium.org, gavinp+prer_chromium.org, pam+watch_chromium.org, nhiroki, oshima+watch_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, darin (slow to review), rouslan+autofillwatch_chromium.org, davidben+watch_chromium.org, plundblad+watch_chromium.org, feature-media-reviews_chromium.org, tfarina, mcasas+watch_chromium.org, benquan, dominich+watch_chromium.org, davemoore+watch_chromium.org, dyu1, grt+watch_chromium.org, estade+watch_chromium.org, stgao, James Su, wjia+watch_chromium.org, kinuko+fileapi, jshin+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace Convert LowerCaseEqualsASCII to take StringPiece. In the current patch this is generally a NOP but will allow me to delete the other 4 variants in a followup (wanted to do that separately since that will require more review, since callsites will be changed in nontrivial ways). In some cases, LowerCaseEqualsASCII is called with a WebString, which no longer is implicitly converted. I added base::string16(...) around such calls to force the right conversion. It happened in these files: window_container_type.cc savable_resources.cc render_view_impl.cc blink_ax_tree_source.cc password_form_conversion_utils.cc translate_helper.cc chrome_render_view_observer.cc dom_serializer_browsertest.cc R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289312

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : gi #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -442 lines) Patch
M base/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M base/i18n/rtl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M base/strings/string_util.h View 3 chunks +20 lines, -16 lines 0 comments Download
M base/strings/string_util.cc View 2 chunks +19 lines, -18 lines 0 comments Download
M chrome/browser/auto_launch_trial.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_extensions.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/visitsegment_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/local_discovery/device_description.cc View 2 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/net/firefox_proxy_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_url_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_properties.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/search/common/webservice_search_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/keyboard_access_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/l10n_string_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/translate/translate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/web_apps.cc View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/element_util.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/utility/importer/bookmark_html_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/content/browser/wallet/form_field_error.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_signin_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/autofill/core/browser/address.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_country.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/contact_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/state_names.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_tamper_detection.cc View 1 2 3 4 5 3 chunks +8 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/common/data_reduction_proxy_headers.cc View 1 2 3 4 3 chunks +10 lines, -10 lines 0 comments Download
M components/dom_distiller/core/viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/google/core/browser/google_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/metrics/serialization/serialization_utils.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/omnibox/autocomplete_input.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/plugins/renderer/mobile_youtube_plugin.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/search_engines/template_url_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/language_detection/language_detection_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/url_fixer/url_fixer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_state_impl_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_stats.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/transition_request_manager.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/appcache/web_application_cache_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/multipart_response_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/site_isolation_policy.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/common/android/address_parser.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/common/android/address_parser_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/window_container_type.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/android/phone_number_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/fetchers/resource_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/savable_resources.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/net/url_request_abort_on_end_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/net/url_request_slow_download_job.cc View 4 chunks +14 lines, -11 lines 0 comments Download
M content/test/plugin/plugin_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/csp_validator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/runtime_custom_bindings.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_test_expectations_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_video_metadata_extractor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/video/capture/win/video_capture_device_factory_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/launcher/launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_mapping_rules.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/mime_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/filter/filter.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M net/http/http_auth.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_auth_gssapi_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_basic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_digest.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M net/http/http_auth_handler_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_ntlm.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_ntlm_portable.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_sspi_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_content_disposition.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M net/http/http_log_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/http/http_response_headers.cc View 1 2 3 7 chunks +14 lines, -12 lines 0 comments Download
M net/http/http_security_headers.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/http/http_util.cc View 9 chunks +16 lines, -14 lines 0 comments Download
M net/http/http_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/net_nacl.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/proxy/proxy_bypass_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_server.cc View 1 2 3 2 chunks +14 lines, -14 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_job_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_basic_handshake_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_handshake_handler.cc View 5 chunks +24 lines, -23 lines 0 comments Download
M pdf/document_loader.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 2 3 4 chunks +14 lines, -14 lines 0 comments Download
M ui/base/l10n/l10n_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/common/fileapi/file_system_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
James: Since you expressed an opinion of how strings should be done, you get this! ...
6 years, 4 months ago (2014-08-07 20:31:17 UTC) #1
jamesr
lgtm https://codereview.chromium.org/448143008/diff/20001/chrome/browser/local_discovery/device_description.cc File chrome/browser/local_discovery/device_description.cc (right): https://codereview.chromium.org/448143008/diff/20001/chrome/browser/local_discovery/device_description.cc#newcode62 chrome/browser/local_discovery/device_description.cc:62: if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyVersion)) { for a file like ...
6 years, 4 months ago (2014-08-07 20:38:25 UTC) #2
brettw
6 years, 4 months ago (2014-08-13 16:23:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #6 manually as 289312.

Powered by Google App Engine
This is Rietveld 408576698