chrome/browser/chromeos/events/event_rewriter.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/events/event_rewriter.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browser_about_handler.cc ('k') | chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/events/event_rewriter.cc

diff --git a/chrome/browser/chromeos/events/event_rewriter.cc b/chrome/browser/chromeos/events/event_rewriter.cc

index 62cff0705fc6f16542d2cea0c8bf21e5ff3f5a93..b68eb6d0147d404be92fed2d8095183a557b9776 100644

--- a/chrome/browser/chromeos/events/event_rewriter.cc

+++ b/chrome/browser/chromeos/events/event_rewriter.cc

@@ -113,9 +113,9 @@ EventRewriter::DeviceType GetDeviceType(const std::string& device_name) {

bool found_apple = false;

bool found_keyboard = false;

for (size_t i = 0; i < tokens.size(); ++i) {

- if (!found_apple && LowerCaseEqualsASCII(tokens[i], "apple"))

+ if (!found_apple && base::LowerCaseEqualsASCII(tokens[i], "apple"))

found_apple = true;

- if (!found_keyboard && LowerCaseEqualsASCII(tokens[i], "keyboard"))

+ if (!found_keyboard && base::LowerCaseEqualsASCII(tokens[i], "keyboard"))

found_keyboard = true;

if (found_apple && found_keyboard)

return EventRewriter::kDeviceAppleKeyboard;