components/autofill/content/browser/wallet/wallet_signin_helper.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/wallet/wallet_signin_helper.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/wallet/wallet_client.cc ('k') | components/autofill/content/renderer/autofill_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/browser/wallet/wallet_signin_helper.cc

diff --git a/components/autofill/content/browser/wallet/wallet_signin_helper.cc b/components/autofill/content/browser/wallet/wallet_signin_helper.cc

index fc9b66fad232324382dc2e8bd413d442438ccc55..766778b81c9376cb41ebf0fe50466a0eadff3dc5 100644

--- a/components/autofill/content/browser/wallet/wallet_signin_helper.cc

+++ b/components/autofill/content/browser/wallet/wallet_signin_helper.cc

@@ -45,8 +45,8 @@ void GetGoogleCookiesCallback(

std::string host = wallet::GetPassiveAuthUrl(0).host();

std::string wallet_cookie;

for (size_t i = 0; i < cookies.size(); ++i) {

- if (LowerCaseEqualsASCII(cookies[i].Name(), kWalletCookieName) &&

- LowerCaseEqualsASCII(cookies[i].Domain(), host.c_str())) {

+ if (base::LowerCaseEqualsASCII(cookies[i].Name(), kWalletCookieName) &&

+ base::LowerCaseEqualsASCII(cookies[i].Domain(), host.c_str())) {

wallet_cookie = cookies[i].Value();

break;

}

@@ -155,7 +155,7 @@ void WalletSigninHelper::OnURLFetchComplete(

return;

}

- if (!LowerCaseEqualsASCII(data, "yes")) {

+ if (!base::LowerCaseEqualsASCII(data, "yes")) {

OnServiceError(

GoogleServiceAuthError(GoogleServiceAuthError::USER_NOT_SIGNED_UP));

return;