Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1275)

Unified Diff: chrome/browser/local_discovery/device_description.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/memory_details.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/local_discovery/device_description.cc
diff --git a/chrome/browser/local_discovery/device_description.cc b/chrome/browser/local_discovery/device_description.cc
index d2faed066544d1082ff9f8a6ed47ad6924906e76..c64bf92c4429baba6bbf061ddb2591f5e38acb4c 100644
--- a/chrome/browser/local_discovery/device_description.cc
+++ b/chrome/browser/local_discovery/device_description.cc
@@ -17,13 +17,15 @@ namespace {
DeviceDescription::ConnectionState
ConnectionStateFromString(const std::string& str) {
- if (LowerCaseEqualsASCII(str, kPrivetConnectionStatusOnline)) {
+ if (base::LowerCaseEqualsASCII(str, kPrivetConnectionStatusOnline)) {
return DeviceDescription::ONLINE;
- } else if (LowerCaseEqualsASCII(str, kPrivetConnectionStatusOffline)) {
+ } else if (base::LowerCaseEqualsASCII(str, kPrivetConnectionStatusOffline)) {
return DeviceDescription::OFFLINE;
- } else if (LowerCaseEqualsASCII(str, kPrivetConnectionStatusConnecting)) {
+ } else if (base::LowerCaseEqualsASCII(str,
+ kPrivetConnectionStatusConnecting)) {
return DeviceDescription::CONNECTING;
- } else if (LowerCaseEqualsASCII(str, kPrivetConnectionStatusNotConfigured)) {
+ } else if (base::LowerCaseEqualsASCII(str,
+ kPrivetConnectionStatusNotConfigured)) {
return DeviceDescription::NOT_CONFIGURED;
}
@@ -57,20 +59,20 @@ void DeviceDescription::FillFromServiceDescription(
std::string key = i->substr(0, equals_pos);
std::string value = i->substr(equals_pos + 1);
- if (LowerCaseEqualsASCII(key, kPrivetTxtKeyVersion)) {
+ if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyVersion)) {
if (!base::StringToInt(value, &version))
continue; // Unknown version.
- } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyName)) {
+ } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyName)) {
name = value;
- } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyDescription)) {
+ } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyDescription)) {
description = value;
- } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyURL)) {
+ } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyURL)) {
url = value;
- } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyType)) {
+ } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyType)) {
type = value;
- } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyID)) {
+ } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyID)) {
id = value;
- } else if (LowerCaseEqualsASCII(key, kPrivetTxtKeyConnectionState)) {
+ } else if (base::LowerCaseEqualsASCII(key, kPrivetTxtKeyConnectionState)) {
connection_state = ConnectionStateFromString(value);
}
}
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/memory_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698