chrome/browser/autocomplete/history_url_provider.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/history_url_provider.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc ('k') | chrome/browser/autocomplete/search_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/history_url_provider.cc

diff --git a/chrome/browser/autocomplete/history_url_provider.cc b/chrome/browser/autocomplete/history_url_provider.cc

index 1f2ad0b00093724b6b9845c45dd1a9c27d9d4dfe..7991e3cb4e874339ca1050afbabf1842b28c28d0 100644

--- a/chrome/browser/autocomplete/history_url_provider.cc

+++ b/chrome/browser/autocomplete/history_url_provider.cc

@@ -973,7 +973,7 @@ bool HistoryURLProvider::CanFindIntranetURL(

// input's text and parts between Parse() and here, it seems better to be

// paranoid and check.

if ((input.type() != metrics::OmniboxInputType::UNKNOWN) ||

- !LowerCaseEqualsASCII(input.scheme(), url::kHttpScheme) ||

+ !base::LowerCaseEqualsASCII(input.scheme(), url::kHttpScheme) ||

!input.parts().host.is_nonempty())

return false;

const std::string host(base::UTF16ToUTF8(