Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3081)

Unified Diff: chrome/test/chromedriver/element_util.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/web_apps.cc ('k') | chrome/utility/importer/bookmark_html_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/element_util.cc
diff --git a/chrome/test/chromedriver/element_util.cc b/chrome/test/chromedriver/element_util.cc
index 274449f7b2c992a3229ef9c405498519af986ced..ddd7db8d841b5f98d56ea8b79dc8db12c5696ae1 100644
--- a/chrome/test/chromedriver/element_util.cc
+++ b/chrome/test/chromedriver/element_util.cc
@@ -338,10 +338,12 @@ Status IsElementAttributeEqualToIgnoreCase(
if (status.IsError())
return status;
std::string actual_value;
- if (result->GetAsString(&actual_value))
- *is_equal = LowerCaseEqualsASCII(actual_value, attribute_value.c_str());
- else
+ if (result->GetAsString(&actual_value)) {
+ *is_equal =
+ base::LowerCaseEqualsASCII(actual_value, attribute_value.c_str());
+ } else {
*is_equal = false;
+ }
return status;
}
« no previous file with comments | « chrome/renderer/web_apps.cc ('k') | chrome/utility/importer/bookmark_html_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698