chrome/renderer/translate/translate_helper.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/translate/translate_helper.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/translate/translate_helper.cc

diff --git a/chrome/renderer/translate/translate_helper.cc b/chrome/renderer/translate/translate_helper.cc

index a05953cbe5804c121ed4197aa03c63577955f050..8629e5bced5cbaee9e1ad55221ae2334f197fb52 100644

--- a/chrome/renderer/translate/translate_helper.cc

+++ b/chrome/renderer/translate/translate_helper.cc

@@ -369,7 +369,7 @@ bool TranslateHelper::IsTranslationAllowed(WebDocument* document) {

attribute = element.getAttribute(content);

if (attribute.isNull())

continue;

- if (LowerCaseEqualsASCII(attribute, "notranslate"))

+ if (base::LowerCaseEqualsASCII(base::string16(attribute), "notranslate"))

return false;

}

return true;

« no previous file with comments | « chrome/renderer/extensions/webstore_bindings.cc ('k') | chrome/renderer/web_apps.cc » ('j') | no next file with comments »