components/translate/core/language_detection/language_detection_util.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/language_detection/language_detection_util.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/translate/core/language_detection/language_detection_util.cc

diff --git a/components/translate/core/language_detection/language_detection_util.cc b/components/translate/core/language_detection/language_detection_util.cc

index 35a21b9019e007035260299103fcf259c355070c..29f4898e1b9b59060ebbcbaac6706067edadbf62 100644

--- a/components/translate/core/language_detection/language_detection_util.cc

+++ b/components/translate/core/language_detection/language_detection_util.cc

@@ -292,7 +292,7 @@ void CorrectLanguageCodeTypo(std::string* code) {

size_t dash_index = code->find('-');

if (dash_index != std::string::npos) {

*code = base::StringToLowerASCII(code->substr(0, dash_index)) +

- StringToUpperASCII(code->substr(dash_index));

+ base::StringToUpperASCII(code->substr(dash_index));

} else {

*code = base::StringToLowerASCII(*code);

}

« no previous file with comments | « components/search_engines/template_url_parser.cc ('k') | components/url_fixer/url_fixer.cc » ('j') | no next file with comments »