components/dom_distiller/core/viewer.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/viewer.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/common/data_reduction_proxy_headers.cc ('k') | components/google/core/browser/google_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/core/viewer.cc

diff --git a/components/dom_distiller/core/viewer.cc b/components/dom_distiller/core/viewer.cc

index be8463a3c67866bf2fc7a5efab6a58335f26232d..cda70f8213177625181e8df88655a883ccd84828 100644

--- a/components/dom_distiller/core/viewer.cc

+++ b/components/dom_distiller/core/viewer.cc

@@ -182,7 +182,7 @@ scoped_ptr<ViewerHandle> CreateViewRequest(

std::string entry_id =

url_utils::GetValueForKeyInUrlPathQuery(path, kEntryIdKey);

bool has_valid_entry_id = !entry_id.empty();

- entry_id = StringToUpperASCII(entry_id);

+ entry_id = base::StringToUpperASCII(entry_id);

std::string requested_url_str =

url_utils::GetValueForKeyInUrlPathQuery(path, kUrlKey);