components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/state_names.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_tamper_detection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc

index a8536687ef9e95c8010b904d0c78df63bbb3b17e..0d8e43f4cabaa89c37f6b468b2d6a5a37af5991a 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc

@@ -586,10 +586,10 @@ bool DataReductionProxySettings::DisableIfVPN() {

const std::string vpn_interface_name_prefix = "tun";

for (size_t i = 0; i < network_interfaces.size(); ++i) {

std::string interface_name = network_interfaces[i].name;

- if (LowerCaseEqualsASCII(

- interface_name.begin(),

- interface_name.begin() + vpn_interface_name_prefix.size(),

- vpn_interface_name_prefix.c_str())) {

+ if (base::LowerCaseEqualsASCII(

+ interface_name.begin(),

+ interface_name.begin() + vpn_interface_name_prefix.size(),

+ vpn_interface_name_prefix.c_str())) {

SetProxyConfigs(false,

IsDataReductionProxyAlternativeEnabled(),

false,