net/http/http_util_unittest.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_util_unittest.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_util_unittest.cc

diff --git a/net/http/http_util_unittest.cc b/net/http/http_util_unittest.cc

index 54acf68d3c3d52c3bc28aa4b0f9ee3603ac098cd..8c08df2821908cddb15ccb1c7db923191af37f5d 100644

--- a/net/http/http_util_unittest.cc

+++ b/net/http/http_util_unittest.cc

@@ -50,7 +50,7 @@ TEST(HttpUtilTest, IsSafeHeader) {

for (size_t i = 0; i < arraysize(unsafe_headers); ++i) {

EXPECT_FALSE(HttpUtil::IsSafeHeader(unsafe_headers[i]))

<< unsafe_headers[i];

- EXPECT_FALSE(HttpUtil::IsSafeHeader(StringToUpperASCII(std::string(

+ EXPECT_FALSE(HttpUtil::IsSafeHeader(base::StringToUpperASCII(std::string(

unsafe_headers[i])))) << unsafe_headers[i];

}

static const char* safe_headers[] = {

@@ -95,7 +95,7 @@ TEST(HttpUtilTest, IsSafeHeader) {

};

for (size_t i = 0; i < arraysize(safe_headers); ++i) {

EXPECT_TRUE(HttpUtil::IsSafeHeader(safe_headers[i])) << safe_headers[i];

- EXPECT_TRUE(HttpUtil::IsSafeHeader(StringToUpperASCII(std::string(

+ EXPECT_TRUE(HttpUtil::IsSafeHeader(base::StringToUpperASCII(std::string(

safe_headers[i])))) << safe_headers[i];

}

« no previous file with comments | « net/http/http_util.cc ('k') | net/net_nacl.gyp » ('j') | no next file with comments »