Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2706)

Unified Diff: chrome/renderer/chrome_render_view_observer.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/l10n_string_util.cc ('k') | chrome/renderer/extensions/webstore_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_render_view_observer.cc
diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc
index bbfe1993cb7afa4df661e8adb046ef8c92eec492..77d3cf1eed3dd4fa6f7fe308becdcbee61d9f730 100644
--- a/chrome/renderer/chrome_render_view_observer.cc
+++ b/chrome/renderer/chrome_render_view_observer.cc
@@ -225,7 +225,7 @@ void ChromeRenderViewObserver::OnRetrieveWebappInformation(
&found_tag,
&content_str);
bool is_mobile_webapp_capable = mobile_parse_success && found_tag &&
- LowerCaseEqualsASCII(content_str, "yes");
+ base::LowerCaseEqualsASCII(content_str, "yes");
// Search for the "apple-mobile-web-app-capable" tag.
bool apple_parse_success = RetrieveMetaTagContent(
@@ -235,7 +235,7 @@ void ChromeRenderViewObserver::OnRetrieveWebappInformation(
&found_tag,
&content_str);
bool is_apple_mobile_webapp_capable = apple_parse_success && found_tag &&
- LowerCaseEqualsASCII(content_str, "yes");
+ base::LowerCaseEqualsASCII(content_str, "yes");
bool is_only_apple_mobile_webapp_capable =
is_apple_mobile_webapp_capable && !is_mobile_webapp_capable;
@@ -470,7 +470,8 @@ bool ChromeRenderViewObserver::HasRefreshMetaTag(WebFrame* frame) {
if (!element.hasHTMLTagName(tag_name))
continue;
WebString value = element.getAttribute(attribute_name);
- if (value.isNull() || !LowerCaseEqualsASCII(value, "refresh"))
+ if (value.isNull() ||
+ !base::LowerCaseEqualsASCII(base::string16(value), "refresh"))
continue;
return true;
}
« no previous file with comments | « chrome/installer/util/l10n_string_util.cc ('k') | chrome/renderer/extensions/webstore_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698