Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: components/omnibox/autocomplete_input.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/autocomplete_input.cc
diff --git a/components/omnibox/autocomplete_input.cc b/components/omnibox/autocomplete_input.cc
index a24d579fd735916bcb44f4a8e7d7120cb1bebf47..2e4f96d13bb20e33b0f90155b7f7a83ee9f1912d 100644
--- a/components/omnibox/autocomplete_input.cc
+++ b/components/omnibox/autocomplete_input.cc
@@ -169,7 +169,7 @@ metrics::OmniboxInputType::Type AutocompleteInput::Parse(
if (!canonicalized_url->is_valid())
return metrics::OmniboxInputType::QUERY;
- if (LowerCaseEqualsASCII(parsed_scheme_utf8, url::kFileScheme)) {
+ if (base::LowerCaseEqualsASCII(parsed_scheme_utf8, url::kFileScheme)) {
// A user might or might not type a scheme when entering a file URL. In
// either case, |parsed_scheme_utf8| will tell us that this is a file URL,
// but |parts->scheme| might be empty, e.g. if the user typed "C:\foo".
@@ -183,8 +183,8 @@ metrics::OmniboxInputType::Type AutocompleteInput::Parse(
// (e.g. "ftp" or "view-source") but I'll wait to spend the effort on that
// until I run into some cases that really need it.
if (parts->scheme.is_nonempty() &&
- !LowerCaseEqualsASCII(parsed_scheme_utf8, url::kHttpScheme) &&
- !LowerCaseEqualsASCII(parsed_scheme_utf8, url::kHttpsScheme)) {
+ !base::LowerCaseEqualsASCII(parsed_scheme_utf8, url::kHttpScheme) &&
+ !base::LowerCaseEqualsASCII(parsed_scheme_utf8, url::kHttpsScheme)) {
metrics::OmniboxInputType::Type type =
scheme_classifier.GetInputTypeForScheme(parsed_scheme_utf8);
if (type != metrics::OmniboxInputType::INVALID)
@@ -422,7 +422,7 @@ void AutocompleteInput::ParseForEmphasizeComponents(
int after_scheme_and_colon = parts.scheme.end() + 1;
// For the view-source scheme, we should emphasize the scheme and host of the
// URL qualified by the view-source prefix.
- if (LowerCaseEqualsASCII(scheme_str, kViewSourceScheme) &&
+ if (base::LowerCaseEqualsASCII(scheme_str, kViewSourceScheme) &&
(static_cast<int>(text.length()) > after_scheme_and_colon)) {
// Obtain the URL prefixed by view-source and parse it.
base::string16 real_url(text.substr(after_scheme_and_colon));
@@ -444,7 +444,7 @@ void AutocompleteInput::ParseForEmphasizeComponents(
host->reset();
}
}
- } else if (LowerCaseEqualsASCII(scheme_str, url::kFileSystemScheme) &&
+ } else if (base::LowerCaseEqualsASCII(scheme_str, url::kFileSystemScheme) &&
parts.inner_parsed() && parts.inner_parsed()->scheme.is_valid()) {
*host = parts.inner_parsed()->host;
}
« no previous file with comments | « components/metrics/serialization/serialization_utils.cc ('k') | components/plugins/renderer/mobile_youtube_plugin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698