Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: components/metrics/serialization/serialization_utils.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/google/core/browser/google_util.cc ('k') | components/omnibox/autocomplete_input.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/serialization/serialization_utils.cc
diff --git a/components/metrics/serialization/serialization_utils.cc b/components/metrics/serialization/serialization_utils.cc
index 6e0be26e98e88b26f47b1f17d628fc9011c6703e..2165bdfc3ebf6baa478f94d2f9b5580298f5470d 100644
--- a/components/metrics/serialization/serialization_utils.cc
+++ b/components/metrics/serialization/serialization_utils.cc
@@ -97,15 +97,15 @@ scoped_ptr<MetricSample> SerializationUtils::ParseSample(
const std::string& name = parts[0];
const std::string& value = parts[1];
- if (LowerCaseEqualsASCII(name, "crash")) {
+ if (base::LowerCaseEqualsASCII(name, "crash")) {
return MetricSample::CrashSample(value);
- } else if (LowerCaseEqualsASCII(name, "histogram")) {
+ } else if (base::LowerCaseEqualsASCII(name, "histogram")) {
return MetricSample::ParseHistogram(value);
- } else if (LowerCaseEqualsASCII(name, "linearhistogram")) {
+ } else if (base::LowerCaseEqualsASCII(name, "linearhistogram")) {
return MetricSample::ParseLinearHistogram(value);
- } else if (LowerCaseEqualsASCII(name, "sparsehistogram")) {
+ } else if (base::LowerCaseEqualsASCII(name, "sparsehistogram")) {
return MetricSample::ParseSparseHistogram(value);
- } else if (LowerCaseEqualsASCII(name, "useraction")) {
+ } else if (base::LowerCaseEqualsASCII(name, "useraction")) {
return MetricSample::UserActionSample(value);
} else {
DLOG(ERROR) << "invalid event type: " << name << ", value: " << value;
« no previous file with comments | « components/google/core/browser/google_util.cc ('k') | components/omnibox/autocomplete_input.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698