Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: net/filter/filter.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/mime_util.cc ('k') | net/http/http_auth.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/filter/filter.cc
diff --git a/net/filter/filter.cc b/net/filter/filter.cc
index d77272a809d99412ad471cc97095adf4abb43f23..0a5695981b35df33fc1f97d06a3acd0559a481f2 100644
--- a/net/filter/filter.cc
+++ b/net/filter/filter.cc
@@ -138,12 +138,12 @@ bool Filter::FlushStreamBuffer(int stream_data_len) {
Filter::FilterType Filter::ConvertEncodingToType(
const std::string& filter_type) {
FilterType type_id;
- if (LowerCaseEqualsASCII(filter_type, kDeflate)) {
+ if (base::LowerCaseEqualsASCII(filter_type, kDeflate)) {
type_id = FILTER_TYPE_DEFLATE;
- } else if (LowerCaseEqualsASCII(filter_type, kGZip) ||
- LowerCaseEqualsASCII(filter_type, kXGZip)) {
+ } else if (base::LowerCaseEqualsASCII(filter_type, kGZip) ||
+ base::LowerCaseEqualsASCII(filter_type, kXGZip)) {
type_id = FILTER_TYPE_GZIP;
- } else if (LowerCaseEqualsASCII(filter_type, kSdch)) {
+ } else if (base::LowerCaseEqualsASCII(filter_type, kSdch)) {
type_id = FILTER_TYPE_SDCH;
} else {
// Note we also consider "identity" and "uncompressed" UNSUPPORTED as
@@ -163,9 +163,9 @@ void Filter::FixupEncodingTypes(
if ((1 == encoding_types->size()) &&
(FILTER_TYPE_GZIP == encoding_types->front())) {
- if (LowerCaseEqualsASCII(mime_type, kApplicationXGzip) ||
- LowerCaseEqualsASCII(mime_type, kApplicationGzip) ||
- LowerCaseEqualsASCII(mime_type, kApplicationXGunzip))
+ if (base::LowerCaseEqualsASCII(mime_type, kApplicationXGzip) ||
+ base::LowerCaseEqualsASCII(mime_type, kApplicationGzip) ||
+ base::LowerCaseEqualsASCII(mime_type, kApplicationXGunzip))
// The server has told us that it sent us gziped content with a gzip
// content encoding. Sadly, Apache mistakenly sets these headers for all
// .gz files. We match Firefox's nsHttpChannel::ProcessNormal and ignore
@@ -190,8 +190,8 @@ void Filter::FixupEncodingTypes(
// want to do that when downloading.
// See Firefox's nonDecodableExtensions in nsExternalHelperAppService.cpp
if (EndsWith(extension, FILE_PATH_LITERAL(".gz"), false) ||
- LowerCaseEqualsASCII(extension, ".tgz") ||
- LowerCaseEqualsASCII(extension, ".svgz"))
+ base::LowerCaseEqualsASCII(extension, ".tgz") ||
+ base::LowerCaseEqualsASCII(extension, ".svgz"))
encoding_types->clear();
} else {
// When the user does not explicitly ask to download a file, if we get a
@@ -199,7 +199,7 @@ void Filter::FixupEncodingTypes(
// However, if it's not a supported mime type, then we will attempt to
// download it, and in that case, don't decompress .gz/.tgz files.
if ((EndsWith(extension, FILE_PATH_LITERAL(".gz"), false) ||
- LowerCaseEqualsASCII(extension, ".tgz")) &&
+ base::LowerCaseEqualsASCII(extension, ".tgz")) &&
!IsSupportedMimeType(mime_type))
encoding_types->clear();
}
« no previous file with comments | « net/base/mime_util.cc ('k') | net/http/http_auth.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698