Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: media/base/audio_video_metadata_extractor.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/audio_video_metadata_extractor.cc
diff --git a/media/base/audio_video_metadata_extractor.cc b/media/base/audio_video_metadata_extractor.cc
index fd666f6c919448ccd386a91e702fa1d9fc5ba101..bde703ae6209346a5bdd865990d6189d6236a51b 100644
--- a/media/base/audio_video_metadata_extractor.cc
+++ b/media/base/audio_video_metadata_extractor.cc
@@ -23,7 +23,7 @@ void OnError(bool* succeeded) {
// Returns true if the |tag| matches |expected_key|.
bool ExtractString(AVDictionaryEntry* tag, const char* expected_key,
std::string* destination) {
- if (!LowerCaseEqualsASCII(std::string(tag->key), expected_key))
+ if (!base::LowerCaseEqualsASCII(tag->key, expected_key))
return false;
if (destination->empty())
@@ -35,7 +35,7 @@ bool ExtractString(AVDictionaryEntry* tag, const char* expected_key,
// Returns true if the |tag| matches |expected_key|.
bool ExtractInt(AVDictionaryEntry* tag, const char* expected_key,
int* destination) {
- if (!LowerCaseEqualsASCII(std::string(tag->key), expected_key))
+ if (!base::LowerCaseEqualsASCII(tag->key, expected_key))
return false;
int temporary = -1;
« no previous file with comments | « gpu/config/gpu_test_expectations_parser.cc ('k') | media/video/capture/win/video_capture_device_factory_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698