components/autofill/core/browser/state_names.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/state_names.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/personal_data_manager.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/state_names.cc

diff --git a/components/autofill/core/browser/state_names.cc b/components/autofill/core/browser/state_names.cc

index d4975b4cb91743ed37b2c17293a869c70fd9a525..de659243be76f8e962997a34ffb649cf4621d2d0 100644

--- a/components/autofill/core/browser/state_names.cc

+++ b/components/autofill/core/browser/state_names.cc

@@ -80,7 +80,7 @@ StateData kStateData[] = {

base::string16 GetAbbreviationForName(const base::string16& name) {

for (size_t i = 0; i < arraysize(kStateData); ++i) {

const StateData& state = kStateData[i];

- if (LowerCaseEqualsASCII(name, state.name))

+ if (base::LowerCaseEqualsASCII(name, state.name))

return base::ASCIIToUTF16(state.abbreviation);

}

return base::string16();

@@ -89,7 +89,7 @@ base::string16 GetAbbreviationForName(const base::string16& name) {

base::string16 GetNameForAbbreviation(const base::string16& abbreviation) {

for (size_t i = 0; i < arraysize(kStateData); ++i) {

const StateData& state = kStateData[i];

- if (LowerCaseEqualsASCII(abbreviation, state.abbreviation))

+ if (base::LowerCaseEqualsASCII(abbreviation, state.abbreviation))

return base::ASCIIToUTF16(state.name);

}

return base::string16();