chrome/browser/ui/login/login_prompt.cc - Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/login/login_prompt.cc

Issue 448143008: Move StringToUpperASCII and LowerCaseEqualsASCII to the base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | chrome/browser/ui/views/keyboard_access_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/login/login_prompt.cc

diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc

index 53f68a7b4a8f518502bdf7c005e1aaa274b15769..0de9b1fc892496c737a337f3257e0e6e00f29dad 100644

--- a/chrome/browser/ui/login/login_prompt.cc

+++ b/chrome/browser/ui/login/login_prompt.cc

@@ -418,9 +418,9 @@ void MakeInputForPasswordManager(

LoginHandler* handler,

std::vector<PasswordForm>* password_manager_input) {

PasswordForm dialog_form;

- if (LowerCaseEqualsASCII(auth_info->scheme, "basic")) {

+ if (base::LowerCaseEqualsASCII(auth_info->scheme, "basic")) {

dialog_form.scheme = PasswordForm::SCHEME_BASIC;

- } else if (LowerCaseEqualsASCII(auth_info->scheme, "digest")) {

+ } else if (base::LowerCaseEqualsASCII(auth_info->scheme, "digest")) {

dialog_form.scheme = PasswordForm::SCHEME_DIGEST;

} else {

dialog_form.scheme = PasswordForm::SCHEME_OTHER;