Distinguish between keystroke and character events.

Distinguish between keystroke and character events.

As described in its class comment, a ui::KeyEvent can be either of two
distinct kinds. When constructing a ui::KeyEvent from a native event,
the distinction is made by a new IsCharFromNative() call, in the same
way that other ui::Event properties are determined, instead of having the
caller inspect the native event itself. Removing the redundant |is_char|
parameter from constructors also prevent accidental synthetic `mixed'
events that consuming code does not handle.

Incidentally, while KeyEvent constructor calls are being touched, use
EF_NONE instead of 0 to make that argument's purpose clear.

BUG=380349
TEST=unit_tests,ash_unittests,events_unittests,ui_unittests,interactive_ui_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285605

[sadrul, 2014-07-23 02:03:55]

+ben@ since I am not that familiar with events on Windows. (the main change in
the CL is in //ui/events/)

[Ben Goodger (Google), 2014-07-23 16:14:23]

Looks like a good improvement.

lgtm

[sadrul, 2014-07-23 16:57:49]

lgtm++ (make sure you run through the ecs_ozone trybot)

[kpschoedel, 2014-07-24 16:33:56]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-24 16:35:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404203003/310001

[kpschoedel, 2014-07-25 14:25:44]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-25 14:26:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/404203003/330001

[commit-bot: I haz the power, 2014-07-25 16:13:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-25 17:10:34]

Change committed as 285605