Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1874)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_engine.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_engine.cc b/chrome/browser/chromeos/input_method/input_method_engine.cc
index 540766af3629248b50864396817c5231ad3d6c5e..031edb1951b34fc6a9d54a8e78de6d65331bceb8 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine.cc
+++ b/chrome/browser/chromeos/input_method/input_method_engine.cc
@@ -83,8 +83,7 @@ std::string GetKeyFromEvent(const ui::KeyEvent& event) {
if (event.flags() & ui::EF_CONTROL_DOWN) {
ui::KeyEvent event_no_ctrl(event.type(),
event.key_code(),
- event.flags() ^ ui::EF_CONTROL_DOWN,
- false);
+ event.flags() ^ ui::EF_CONTROL_DOWN);
ch = event_no_ctrl.GetCharacter();
} else {
ch = event.GetCharacter();
@@ -317,8 +316,7 @@ bool InputMethodEngine::SendKeyEvents(
ui::KeyEvent ui_event(type,
key_code,
event.code,
- flags,
- false /* is_char */);
+ flags);
if (!event.key.empty())
ui_event.set_character(base::UTF8ToUTF16(event.key)[0]);
base::AutoReset<const ui::KeyEvent*> reset_sent_key(&sent_key_event_,

Powered by Google App Engine
This is Rietveld 408576698