ui/aura/remote_window_tree_host_win.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/remote_window_tree_host_win.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/remote_window_tree_host_win.cc

diff --git a/ui/aura/remote_window_tree_host_win.cc b/ui/aura/remote_window_tree_host_win.cc

index c3d09c36794a6c2d3dedd9cf4e08046be3649ac4..06c0aeed87a209884dd0bb4af7faa8d2cd7903de 100644

--- a/ui/aura/remote_window_tree_host_win.cc

+++ b/ui/aura/remote_window_tree_host_win.cc

@@ -499,11 +499,15 @@ void RemoteWindowTreeHostWin::DispatchKeyboardMessage(ui::EventType type,

message,

vkey,

repeat_count | scan_code >> 15);

+ } else if (is_character) {

+ ui::KeyEvent event(static_cast<base::char16>(vkey),

+ ui::KeyboardCodeForWindowsKeyCode(vkey),

+ flags);

+ SendEventToProcessor(&event);

} else {

ui::KeyEvent event(type,

ui::KeyboardCodeForWindowsKeyCode(vkey),

- flags,

- is_character);

+ flags);

SendEventToProcessor(&event);

}