Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: ui/views/controls/textfield/textfield_unittest.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/table/table_view_unittest.cc ('k') | ui/views/focus/focus_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield_unittest.cc
diff --git a/ui/views/controls/textfield/textfield_unittest.cc b/ui/views/controls/textfield/textfield_unittest.cc
index c41bb9b062e2e97b932b5044467eac448229c32c..ec4b578e20fe7595bf9fc9c5cd034d5a59416572 100644
--- a/ui/views/controls/textfield/textfield_unittest.cc
+++ b/ui/views/controls/textfield/textfield_unittest.cc
@@ -252,7 +252,7 @@ class TextfieldTest : public ViewsTestBase, public TextfieldController {
(shift ? ui::EF_SHIFT_DOWN : 0) |
(control ? ui::EF_CONTROL_DOWN : 0) |
(caps_lock ? ui::EF_CAPS_LOCK_DOWN : 0);
- ui::KeyEvent event(ui::ET_KEY_PRESSED, key_code, flags, false);
+ ui::KeyEvent event(ui::ET_KEY_PRESSED, key_code, flags);
input_method_->DispatchKeyEvent(event);
}
@@ -271,8 +271,7 @@ class TextfieldTest : public ViewsTestBase, public TextfieldController {
static_cast<ui::KeyboardCode>(ui::VKEY_A + ch - 'a');
SendKeyEvent(code);
} else {
- ui::KeyEvent event(ui::ET_KEY_PRESSED, ui::VKEY_UNKNOWN, 0, false);
- event.set_character(ch);
+ ui::KeyEvent event(ch, ui::VKEY_UNKNOWN, ui::EF_NONE);
input_method_->DispatchKeyEvent(event);
}
}
« no previous file with comments | « ui/views/controls/table/table_view_unittest.cc ('k') | ui/views/focus/focus_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698