chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc - Issue 404203003: Distinguish between keystroke and character events.

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

index 494371f1a1a2188ccbbbe40e8f98b64b7b260620..fe428bb6f780d200e46ee35588ce26e2739750c4 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

@@ -186,7 +186,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

// onKeyEvent should be fired if ProcessKeyEvent is called.

KeyEventDoneCallback callback(false); // EchoBackIME doesn't consume keys.

ExtensionTestMessageListener keyevent_listener("onKeyEvent", false);

- ui::KeyEvent key_event(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::EF_NONE, false);

+ ui::KeyEvent key_event(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::EF_NONE);

engine_handler->ProcessKeyEvent(key_event,

base::Bind(&KeyEventDoneCallback::Run,

base::Unretained(&callback)));

@@ -267,7 +267,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

ExtensionTestMessageListener keyevent_listener(expected_value, false);

ui::KeyEvent key_event(

- ui::ET_KEY_PRESSED, ui::VKEY_A, "KeyA", ui::EF_NONE, false);

+ ui::ET_KEY_PRESSED, ui::VKEY_A, "KeyA", ui::EF_NONE);

engine_handler->ProcessKeyEvent(key_event,

base::Bind(&KeyEventDoneCallback::Run,

base::Unretained(&callback)));

@@ -285,8 +285,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

ui::KeyEvent key_event(ui::ET_KEY_PRESSED,

ui::VKEY_A,

"KeyA",

- ui::EF_CONTROL_DOWN,

- false);

+ ui::EF_CONTROL_DOWN);

engine_handler->ProcessKeyEvent(key_event,

base::Bind(&KeyEventDoneCallback::Run,

base::Unretained(&callback)));

@@ -304,8 +303,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

ui::KeyEvent key_event(ui::ET_KEY_PRESSED,

ui::VKEY_A,

"KeyA",

- ui::EF_ALT_DOWN,

- false);

+ ui::EF_ALT_DOWN);

engine_handler->ProcessKeyEvent(key_event,

base::Bind(&KeyEventDoneCallback::Run,

base::Unretained(&callback)));

@@ -323,8 +321,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

ui::KeyEvent key_event(ui::ET_KEY_PRESSED,

ui::VKEY_A,

"KeyA",

- ui::EF_SHIFT_DOWN,

- false);

+ ui::EF_SHIFT_DOWN);

engine_handler->ProcessKeyEvent(key_event,

base::Bind(&KeyEventDoneCallback::Run,

base::Unretained(&callback)));

@@ -342,8 +339,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

ui::KeyEvent key_event(ui::ET_KEY_PRESSED,

ui::VKEY_A,

"KeyA",

- ui::EF_CAPS_LOCK_DOWN,

- false);

+ ui::EF_CAPS_LOCK_DOWN);

engine_handler->ProcessKeyEvent(key_event,

base::Bind(&KeyEventDoneCallback::Run,

base::Unretained(&callback)));

@@ -361,8 +357,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

ui::KeyEvent key_event(ui::ET_KEY_PRESSED,

ui::VKEY_A,

"KeyA",

- ui::EF_ALT_DOWN | ui::EF_CONTROL_DOWN,

- false);

+ ui::EF_ALT_DOWN | ui::EF_CONTROL_DOWN);

engine_handler->ProcessKeyEvent(key_event,

base::Bind(&KeyEventDoneCallback::Run,

base::Unretained(&callback)));

@@ -380,8 +375,7 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

ui::KeyEvent key_event(ui::ET_KEY_PRESSED,

ui::VKEY_A,

"KeyA",

- ui::EF_SHIFT_DOWN | ui::EF_CAPS_LOCK_DOWN,

- false);

+ ui::EF_SHIFT_DOWN | ui::EF_CAPS_LOCK_DOWN);

engine_handler->ProcessKeyEvent(key_event,

base::Bind(&KeyEventDoneCallback::Run,

base::Unretained(&callback)));