ash/shelf/shelf.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shelf/shelf.cc

diff --git a/ash/shelf/shelf.cc b/ash/shelf/shelf.cc

index f9d3704fa02e646da7ae60d60d8c0ff881adb5fd..08f32e2bc68979e6f86f0f5339cff6918a8068e0 100644

--- a/ash/shelf/shelf.cc

+++ b/ash/shelf/shelf.cc

@@ -105,8 +105,7 @@ void Shelf::ActivateShelfItem(int index) {

// next item if the current one is already active.

ui::KeyEvent event(ui::ET_KEY_RELEASED,

ui::VKEY_UNKNOWN, // The actual key gets ignored.

- ui::EF_NONE,

- false);

+ ui::EF_NONE);

const ShelfItem& item = shelf_view_->model()->items()[index];

ShelfItemDelegate* item_delegate =