ash/wm/window_manager_unittest.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/window_manager_unittest.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/wm/window_manager_unittest.cc

diff --git a/ash/wm/window_manager_unittest.cc b/ash/wm/window_manager_unittest.cc

index cc1a6759dd21429d0380f1516509c786c393162f..75b7e4e9b80f2ffabf4151bc12e50ef3062f9c8d 100644

--- a/ash/wm/window_manager_unittest.cc

+++ b/ash/wm/window_manager_unittest.cc

@@ -185,7 +185,7 @@ TEST_F(WindowManagerTest, Focus) {

ui::EventProcessor* dispatcher = root_window->GetHost()->event_processor();

// The key press should be sent to the focused sub-window.

- ui::KeyEvent keyev(ui::ET_KEY_PRESSED, ui::VKEY_E, 0, false);

+ ui::KeyEvent keyev(ui::ET_KEY_PRESSED, ui::VKEY_E, ui::EF_NONE);

ui::EventDispatchDetails details = dispatcher->OnEventFromSource(&keyev);

ASSERT_FALSE(details.dispatcher_destroyed);

EXPECT_EQ(ui::VKEY_E, w121delegate->last_key_code());

@@ -671,7 +671,7 @@ TEST_F(WindowManagerTest, AdditionalFilters) {

env_filter->AddHandler(f2.get());

// Dispatches mouse and keyboard events.

- ui::KeyEvent key_event(ui::ET_KEY_PRESSED, ui::VKEY_A, 0, false);

+ ui::KeyEvent key_event(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::EF_NONE);

ui::EventProcessor* dispatcher = root_window->GetHost()->event_processor();

ui::EventDispatchDetails details = dispatcher->OnEventFromSource(&key_event);

ASSERT_FALSE(details.dispatcher_destroyed);