Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: ui/events/event_processor_unittest.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/event.cc ('k') | ui/events/event_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event_processor_unittest.cc
diff --git a/ui/events/event_processor_unittest.cc b/ui/events/event_processor_unittest.cc
index 048a4cdeae925d38af2a55f0764f2a2bf21daa72..b50f24d9587a6684e16d2fe4b8b6c9c0c8487b42 100644
--- a/ui/events/event_processor_unittest.cc
+++ b/ui/events/event_processor_unittest.cc
@@ -252,7 +252,7 @@ TEST_F(EventProcessorTest, DispatchToNextBestTarget) {
// When the root has a BubblingEventTargeter installed, events targeted
// at the grandchild target should be dispatched to all three targets.
- KeyEvent key_event(ET_KEY_PRESSED, VKEY_ESCAPE, 0, false);
+ KeyEvent key_event(ET_KEY_PRESSED, VKEY_ESCAPE, EF_NONE);
DispatchEvent(&key_event);
EXPECT_TRUE(root()->DidReceiveEvent(ET_KEY_PRESSED));
EXPECT_TRUE(child_r->DidReceiveEvent(ET_KEY_PRESSED));
@@ -265,7 +265,7 @@ TEST_F(EventProcessorTest, DispatchToNextBestTarget) {
// as handled. No targets in the hierarchy should receive the event.
TestEventHandler handler;
child_r->AddPreTargetHandler(&handler);
- key_event = KeyEvent(ET_KEY_PRESSED, VKEY_ESCAPE, 0, false);
+ key_event = KeyEvent(ET_KEY_PRESSED, VKEY_ESCAPE, EF_NONE);
DispatchEvent(&key_event);
EXPECT_FALSE(root()->DidReceiveEvent(ET_KEY_PRESSED));
EXPECT_FALSE(child_r->DidReceiveEvent(ET_KEY_PRESSED));
@@ -278,7 +278,7 @@ TEST_F(EventProcessorTest, DispatchToNextBestTarget) {
// event.
child_r->RemovePreTargetHandler(&handler);
child_r->AddPostTargetHandler(&handler);
- key_event = KeyEvent(ET_KEY_PRESSED, VKEY_ESCAPE, 0, false);
+ key_event = KeyEvent(ET_KEY_PRESSED, VKEY_ESCAPE, EF_NONE);
DispatchEvent(&key_event);
EXPECT_FALSE(root()->DidReceiveEvent(ET_KEY_PRESSED));
EXPECT_FALSE(child_r->DidReceiveEvent(ET_KEY_PRESSED));
@@ -292,7 +292,7 @@ TEST_F(EventProcessorTest, DispatchToNextBestTarget) {
// dispatch at the child of the root. The child and grandchild
// targets should both receive the event, but the root should not.
child_r->set_mark_events_as_handled(true);
- key_event = KeyEvent(ET_KEY_PRESSED, VKEY_ESCAPE, 0, false);
+ key_event = KeyEvent(ET_KEY_PRESSED, VKEY_ESCAPE, EF_NONE);
DispatchEvent(&key_event);
EXPECT_FALSE(root()->DidReceiveEvent(ET_KEY_PRESSED));
EXPECT_TRUE(child_r->DidReceiveEvent(ET_KEY_PRESSED));
« no previous file with comments | « ui/events/event.cc ('k') | ui/events/event_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698