chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc ('k') | content/browser/renderer_host/web_input_event_aura_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc

diff --git a/chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc b/chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc

index 04afb9f74d54294c626df44cb3d33e7ac8e1acde..470eabd0225f3e70563295d2dfef60c41ad70a2e 100644

--- a/chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc

+++ b/chrome/browser/ui/views/extensions/media_galleries_dialog_views_unittest.cc

@@ -95,7 +95,7 @@ TEST_F(MediaGalleriesDialogTest, ToggleCheckboxes) {

views::Checkbox* checkbox = dialog.checkbox_map_[1]->checkbox();

EXPECT_TRUE(checkbox->checked());

- ui::KeyEvent dummy_event(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::EF_NONE, false);

+ ui::KeyEvent dummy_event(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::EF_NONE);

EXPECT_CALL(*controller(), DidToggleEntry(1, false));

checkbox->SetChecked(false);

dialog.ButtonPressed(checkbox, dummy_event);