ash/shelf/shelf_tooltip_manager_unittest.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shelf/shelf_tooltip_manager_unittest.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shelf/shelf_tooltip_manager_unittest.cc

diff --git a/ash/shelf/shelf_tooltip_manager_unittest.cc b/ash/shelf/shelf_tooltip_manager_unittest.cc

index 44237d3b90216597eec37c9cf9d765dd9871a131..295c7e9e46dd371dcaefaf18ade0e2179506d650 100644

--- a/ash/shelf/shelf_tooltip_manager_unittest.cc

+++ b/ash/shelf/shelf_tooltip_manager_unittest.cc

@@ -183,7 +183,7 @@ TEST_F(ShelfTooltipManagerTest, ShouldHideForEvents) {

ui::EventHandler* event_handler = GetEventHandler();

// Should not hide for key events.

- ui::KeyEvent key_event(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::EF_NONE, false);

+ ui::KeyEvent key_event(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::EF_NONE);

SetEventTarget(root_window, &key_event);

event_handler->OnKeyEvent(&key_event);

EXPECT_FALSE(key_event.handled());

« no previous file with comments | « ash/shelf/shelf.cc ('k') | ash/sticky_keys/sticky_keys_unittest.cc » ('j') | no next file with comments »