ui/chromeos/touch_exploration_controller_unittest.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/chromeos/touch_exploration_controller_unittest.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/chromeos/touch_exploration_controller_unittest.cc

diff --git a/ui/chromeos/touch_exploration_controller_unittest.cc b/ui/chromeos/touch_exploration_controller_unittest.cc

index b00814b1eb6efc7f6d197292016f8956e693d1a7..127a5cfcfd49f0f1ca511b442a6bc262082a567d 100644

--- a/ui/chromeos/touch_exploration_controller_unittest.cc

+++ b/ui/chromeos/touch_exploration_controller_unittest.cc

@@ -389,17 +389,17 @@ void AssertDirectionalNavigationEvents(const ScopedVector<ui::Event>& events,

ui::KeyboardCode direction) {

ASSERT_EQ(6U, events.size());

ui::KeyEvent shift_pressed(

- ui::ET_KEY_PRESSED, ui::VKEY_SHIFT, ui::EF_SHIFT_DOWN, false);

+ ui::ET_KEY_PRESSED, ui::VKEY_SHIFT, ui::EF_SHIFT_DOWN);

ui::KeyEvent search_pressed(

- ui::ET_KEY_PRESSED, ui::VKEY_LWIN, ui::EF_SHIFT_DOWN, false);

+ ui::ET_KEY_PRESSED, ui::VKEY_LWIN, ui::EF_SHIFT_DOWN);

ui::KeyEvent direction_pressed(

- ui::ET_KEY_PRESSED, direction, ui::EF_SHIFT_DOWN, false);

+ ui::ET_KEY_PRESSED, direction, ui::EF_SHIFT_DOWN);

ui::KeyEvent direction_released(

- ui::ET_KEY_RELEASED, direction, ui::EF_SHIFT_DOWN, false);

+ ui::ET_KEY_RELEASED, direction, ui::EF_SHIFT_DOWN);

ui::KeyEvent search_released(

- ui::ET_KEY_RELEASED, VKEY_LWIN, ui::EF_SHIFT_DOWN, false);

+ ui::ET_KEY_RELEASED, VKEY_LWIN, ui::EF_SHIFT_DOWN);

ui::KeyEvent shift_released(

- ui::ET_KEY_RELEASED, ui::VKEY_SHIFT, ui::EF_NONE, false);

+ ui::ET_KEY_RELEASED, ui::VKEY_SHIFT, ui::EF_NONE);

CONFIRM_EVENTS_ARE_KEY_AND_EQUAL(&shift_pressed, events[0]);

CONFIRM_EVENTS_ARE_KEY_AND_EQUAL(&search_pressed, events[1]);

CONFIRM_EVENTS_ARE_KEY_AND_EQUAL(&direction_pressed, events[2]);

« no previous file with comments | « ui/chromeos/touch_exploration_controller.cc ('k') | ui/events/cocoa/events_mac.mm » ('j') | no next file with comments »