ui/base/ime/input_method_win.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method_win.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/ime/input_method_win.cc

diff --git a/ui/base/ime/input_method_win.cc b/ui/base/ime/input_method_win.cc

index 9b23c1a03592815fee2f4b1a26059f09c762ccf9..33e3ca6f0160112fdbd3b750151819e61e55cce5 100644

--- a/ui/base/ime/input_method_win.cc

+++ b/ui/base/ime/input_method_win.cc

@@ -119,8 +119,7 @@ bool InputMethodWin::DispatchKeyEvent(const ui::KeyEvent& event) {

if (ui::IMM32Manager::IsRTLKeyboardLayoutInstalled() &&

!IsTextInputTypeNone()) {

// TODO: shouldn't need to generate a KeyEvent here.

- const ui::KeyEvent key(native_key_event,

- native_key_event.message == WM_CHAR);

+ const ui::KeyEvent key(native_key_event);

ui::KeyboardCode code = key.key_code();

if (key.type() == ui::ET_KEY_PRESSED) {

if (code == ui::VKEY_SHIFT) {