ui/views/win/hwnd_message_handler.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/win/hwnd_message_handler.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/win/hwnd_message_handler.cc

diff --git a/ui/views/win/hwnd_message_handler.cc b/ui/views/win/hwnd_message_handler.cc

index f8b7f86a2793c61241990bc91a4a0fb627cf9b4f..0e513db03d740ecc6d42ab23db1240f497c686eb 100644

--- a/ui/views/win/hwnd_message_handler.cc

+++ b/ui/views/win/hwnd_message_handler.cc

@@ -1491,7 +1491,7 @@ LRESULT HWNDMessageHandler::OnKeyEvent(UINT message,

WPARAM w_param,

LPARAM l_param) {

MSG msg = { hwnd(), message, w_param, l_param, GetMessageTime() };

- ui::KeyEvent key(msg, message == WM_CHAR);

+ ui::KeyEvent key(msg);

if (!delegate_->HandleUntranslatedKeyEvent(key))

DispatchKeyEventPostIME(key);

return 0;

« no previous file with comments | « ui/views/widget/widget_unittest.cc ('k') | ui/views/window/dialog_delegate_unittest.cc » ('j') | no next file with comments »