ui/views/widget/widget_unittest.cc - Issue 404203003: Distinguish between keystroke and character events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 404203003: Distinguish between keystroke and character events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsCharFromNative() for Mac build Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/widget_unittest.cc

diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc

index a4ac6e4a42c0aa876812191ab9cbb83a483f078e..f6d1ea263b1b0d3c38d91d4cdfa11b53caa86eca 100644

--- a/ui/views/widget/widget_unittest.cc

+++ b/ui/views/widget/widget_unittest.cc

@@ -993,10 +993,10 @@ TEST_F(WidgetTest, KeyboardInputEvent) {

textfield->RequestFocus();

// The press gets handled. The release doesn't have an effect.

- ui::KeyEvent backspace_p(ui::ET_KEY_PRESSED, ui::VKEY_DELETE, 0, false);

+ ui::KeyEvent backspace_p(ui::ET_KEY_PRESSED, ui::VKEY_DELETE, ui::EF_NONE);

toplevel->OnKeyEvent(&backspace_p);

EXPECT_TRUE(backspace_p.stopped_propagation());

- ui::KeyEvent backspace_r(ui::ET_KEY_RELEASED, ui::VKEY_DELETE, 0, false);

+ ui::KeyEvent backspace_r(ui::ET_KEY_RELEASED, ui::VKEY_DELETE, ui::EF_NONE);

toplevel->OnKeyEvent(&backspace_r);

EXPECT_FALSE(backspace_r.handled());

« no previous file with comments | « ui/views/widget/root_view_unittest.cc ('k') | ui/views/win/hwnd_message_handler.cc » ('j') | no next file with comments »